I typically just use a sticky piston to adjust the fall height between “instant death” and “XP/loot grinding”, and adjust the mob killing chamber wall height using stairs and slabs to prevent line of sight so skeletons and the like dont shoot each other trying to hit the player