cute_noker@feddit.dk to Programmer Humor@programming.dev · 16 days agois my PR big enough ?feddit.dkimagemessage-square37fedilinkarrow-up11arrow-down10
arrow-up11arrow-down1imageis my PR big enough ?feddit.dkcute_noker@feddit.dk to Programmer Humor@programming.dev · 16 days agomessage-square37fedilink
minus-squareFMT99@lemmy.worldlinkfedilinkarrow-up0·16 days agoI err on the side of splitting because of what Scratch just said. If I give my colleague 2k lines to review it’ll get slapped with a LGTM and passed. If I send them 100 lines they’ll actually look at it.
minus-squareBoomkop3@reddthat.comlinkfedilinkarrow-up0·16 days agoLooks good to me, are you getting the rocket?
I err on the side of splitting because of what Scratch just said. If I give my colleague 2k lines to review it’ll get slapped with a LGTM and passed. If I send them 100 lines they’ll actually look at it.
LGTM= let’s go to the moon?
Looks good to me, are you getting the rocket?